Add custom ExchangeId generator support #788
Conversation
| /** | ||
| * @since 5.1 | ||
| */ | ||
| public void setExchangeId(final String exchangeId) { | ||
| this.exchangeId = exchangeId; | ||
| } | ||
|
|
||
| /** | ||
| * @since 5.7 | ||
| */ | ||
| public String setExchangeId(final Supplier<String> supplier) { | ||
| final String exchangeId = this.exchangeId; // avoid getfield opcode | ||
| if (exchangeId == null) { | ||
| return this.exchangeId = supplier.get(); | ||
| } else { | ||
| return exchangeId; | ||
| } | ||
| } |
There was a problem hiding this comment.
This looks incoherent. I'd expect the client builders to simply take a Supplier<String> exchangeIdSupplier, which defaults to ExecSupport::getNextExchangeId. The context classes shouldn't need to know about what supplies the exchange IDs, they should just know the exchange ID for the particular exchange they represent.
There was a problem hiding this comment.
Also, there should be a documented contract for custom exchange ID suppliers, i.e. they must return a unique, non-null, non-blank string every time they are called.
There was a problem hiding this comment.
You're right. I'll refactor the implementation.
There was a problem hiding this comment.
@rschmitt I've implemented the changes as discussed. The ExchangeIdGenerator interface has been added to allow custom exchange ID generation. Please review when convenient. Thank you!
yhzdys
force-pushed
the
master
branch
2 times, most recently
from
d6326b4 to
5069736
Compare
yhzdys
changed the title
2 participants
Add ExchangeIdGenerator interface to allow users to customize exchange ID generation in HTTP clients.
This change introduces the ExchangeIdGenerator interface, which enables users to provide custom strategies for generating exchange identifiers. This is particularly useful in distributed systems where custom tracing and correlation mechanisms are required.